-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Gift Profit Tracker #3072
Open
DavidArthurCole
wants to merge
9
commits into
hannibal002:beta
Choose a base branch
from
DavidArthurCole:GiftTracker
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Backend
A backend pull request that will be merged soon
label
Dec 16, 2024
Party gifts have a PARTY tier according to the official wiki, could add that next to SANTA, though I can't test either. |
Next time alpha is open I'll make a concerted effort to open a couple and see if I can easily add them to this |
hannibal002
changed the title
Feature + Backend: Gift Profit Tracker
Feature: Gift Profit Tracker
Dec 17, 2024
github-actions
bot
removed
the
Backend
A backend pull request that will be merged soon
label
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://discord.com/channels/997079228510117908/1140705792937443448
Adds a profit tracker for opened gifts.
Technically has support for Party Gifts, but given the absurd price of those, and my lack of billions of coins to burn on getting chat patterns, this will solely track white/green/red gifts for now (unless the patterns are the same, I guess).
There are likely some items that are going to fail to map from the messages to the tracker. I had to add edge-case detection for Ice Runes, probably gonna be more... god bless beta testers.
Images
Changelog New Features
/shaddusedgifts
.Changelog Technical Details
gifting
package. - Daveed