Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend: Add the regex 101 link when a pattern fails #3034

Merged
merged 3 commits into from
Dec 8, 2024
Merged

Backend: Add the regex 101 link when a pattern fails #3034

merged 3 commits into from
Dec 8, 2024

Conversation

CalMWolfs
Copy link
Collaborator

@CalMWolfs CalMWolfs commented Dec 8, 2024 •
edited by hannibal002
Loading

What

Show regex101 link when there is a failing detekt rule on a regex test

Changelog Technical Details

  • Show a regex101 link when a detekt rule fails on a regex test. - CalMWolfs

@github-actions github-actions bot added Backend A backend pull request that will be merged soon Detekt Has detekt problem labels Dec 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2024 •
edited by CalMWolfs
Loading

One or more Detekt Failures were detected:

  • FriendAPI.kt#L59: Repo pattern rawNamePattern failed regex test: §eClick here to viaaaaaaew §bThrowpo§e's profile pattern: §eClick here to view §.(?<name>.*)§e's profile. View on Regex101

Repository owner deleted a comment from github-actions bot Dec 8, 2024
@CalMWolfs CalMWolfs enabled auto-merge (squash) December 8, 2024 10:43
@CalMWolfs CalMWolfs added this to the Version 0.28 milestone Dec 8, 2024
@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 8, 2024
@CalMWolfs CalMWolfs merged commit 18afe80 into hannibal002:beta Dec 8, 2024
6 checks passed
@github-actions github-actions bot removed the Backend A backend pull request that will be merged soon label Dec 8, 2024
@CalMWolfs CalMWolfs deleted the detekt-regex-101-link branch December 8, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.28
Development

Successfully merging this pull request may close these issues.
1 participant
@CalMWolfs