Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Adds a chat filter to being hit by a venom shot #3032

Merged

Conversation

BearySuperior
Copy link
Contributor

@BearySuperior BearySuperior commented Dec 8, 2024

What

https://discord.com/channels/997079228510117908/1295179982078742590/1295179982078742590
Adds a chat filter to being hit by a venom shot

Changelog Improvements

  • Added Venom Shot attacks to the Arachne chat filter. - BearySuperior

Copy link

github-actions bot commented Dec 8, 2024

I have detected some issues with your pull request:

Body issues:
No changes detected in this pull request

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Dec 8, 2024
@BearySuperior BearySuperior changed the title Adds a chat filter to being hit by a venom shot Feature: Adds a chat filter to being hit by a venom shot Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

I have detected some issues with your pull request:

Body issues:
No changes detected in this pull request

Please fix these issues. For the correct format, refer to the pull request template.

Copy link

github-actions bot commented Dec 8, 2024

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Added Venom Shot Chat Filter

Please fix these issues. For the correct format, refer to the pull request template.

1 similar comment
Copy link

github-actions bot commented Dec 8, 2024

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Added Venom Shot Chat Filter

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Dec 8, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will probably have more requested changes once this is changed

https://discord.com/channels/997079228510117908/1295179982078742590/1315162402828058654
Adds a chat filter for Arachne's venom shot

## Changelog New Features
+ Adds a chat filter for the Venom Shot - BearySuperior
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Added Venom Shot attacks to the Arachne chat filter

Title issues:
PR has category 'Feature' which is not in the changelog. Expected categories: Improvement

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added the Detekt Has detekt problem label Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

One or more Detekt Failures were detected:

  • ArachneChatMessageHider.kt#L40: Repo pattern venomShotPattern failed regex test: §dArachne's Keeper used §r§2Venom Shot §r§don you hitting you for §r§c87.7 damage §r§dand infecting you with venom pattern: §dArachne('s Keeper)? used §r§2Venom Shot §r§don you hitting you for §r§c\d*\.\d damage §r§dand infecting you with venom\..
  • ArachneChatMessageHider.kt#L40: Repo pattern venomShotPattern must not contain unnamed capture groups.
  • ArachneChatMessageHider.kt#L58: Unexpected indentation (12) (should be 8)
  • ArachneChatMessageHider.kt#L52: Function shouldHide has 7 return statements which exceeds the limit of 5.

Copy link

github-actions bot commented Dec 8, 2024

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Added Venom Shot attacks to the Arachne chat filter.

Title issues:
PR has category 'Feature' which is not in the changelog. Expected categories: Improvement

Please fix these issues. For the correct format, refer to the pull request template.

https://discord.com/channels/997079228510117908/1295179982078742590/1315162402828058654
Adds a chat filter for Arachne's venom shot

## Changelog New Features
+ Adds a chat filter for the Venom Shot - BearySuperior
@BearySuperior BearySuperior changed the title Feature: Adds a chat filter to being hit by a venom shot Improvement: Adds a chat filter to being hit by a venom shot Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Added Venom Shot attacks to the Arachne chat filter.

Please fix these issues. For the correct format, refer to the pull request template.

Copy link

github-actions bot commented Dec 8, 2024

One or more Detekt Failures were detected:

  • ArachneChatMessageHider.kt#L42: Repo pattern venomShotPattern failed regex test: §dArachne's Brood used §r§2Venom Shot §r§don you hitting you for §r§c19.8 damage §r§dand infecting you with venom. pattern: §dArachne('s Keeper)? used §r§2Venom Shot §r§don you hitting you for §r§c[\d.,]+ damage §r§dand infecting you with venom\..
  • ArachneChatMessageHider.kt#L42: Repo pattern venomShotPattern must not contain unnamed capture groups.
  • ArachneChatMessageHider.kt#L54: Function shouldHide has 7 return statements which exceeds the limit of 5.

https://discord.com/channels/997079228510117908/1295179982078742590/1315162402828058654
Adds a chat filter for Arachne's venom shot

## Changelog New Features
+ Adds a chat filter for the Venom Shot - BearySuperior
Copy link

github-actions bot commented Dec 8, 2024

One or more Detekt Failures were detected:

  • ArachneChatMessageHider.kt#L42: Repo pattern venomShotPattern failed regex test: §dArachne's Keeper used §r§2Venom Shot §r§don you hitting you for §r§c87.7 damage §r§dand infecting you with venom. pattern: §dArachne(?:'s (?:Keeper|Brood))? used §r§2Venom Shot §r§don you hitting you for §r§c[\\d.,]+ damage §r§dand infecting you with venom\\..
  • ArachneChatMessageHider.kt#L42: Repo pattern venomShotPattern failed regex test: §dArachne used §r§2Venom Shot §r§don you hitting you for §r§c58 damage §r§dand infecting you with venom. pattern: §dArachne(?:'s (?:Keeper|Brood))? used §r§2Venom Shot §r§don you hitting you for §r§c[\\d.,]+ damage §r§dand infecting you with venom\\..
  • ArachneChatMessageHider.kt#L42: Repo pattern venomShotPattern failed regex test: §dArachne's Brood used §r§2Venom Shot §r§don you hitting you for §r§c19.8 damage §r§dand infecting you with venom. pattern: §dArachne(?:'s (?:Keeper|Brood))? used §r§2Venom Shot §r§don you hitting you for §r§c[\\d.,]+ damage §r§dand infecting you with venom\\..
  • ArachneChatMessageHider.kt#L55: Function shouldHide has 7 return statements which exceeds the limit of 5.
  • ArachneChatMessageHider.kt#L44: Line detected, which is longer than the defined maximum line length in the code style.

@github-actions github-actions bot removed Detekt Has detekt problem Wrong Title/Changelog There is an error in the title or changelog labels Dec 8, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Dec 8, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Dec 8, 2024
@hannibal002 hannibal002 enabled auto-merge (squash) December 13, 2024 08:43
@github-actions github-actions bot added the Detekt Has detekt problem label Dec 13, 2024
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 13, 2024
@hannibal002 hannibal002 merged commit e67c258 into hannibal002:beta Dec 13, 2024
6 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants