Feature: Block Opening /cf Without Hot Chocolate Mixin

[DavidArthurCole]

What

https://discord.com/channels/997079228510117908/1314046959589261372
Adds Hot Chocolate Mixin & God Potion detection to the list of reasons /cf/clicking on CF items can be blocked

Changelog New Features

• Added ability to block opening Chocolate Factory without Hot Chocolate Mixin active. - Daveed

[github-actions]

One or more Detekt Failures were detected:

• ChocolateFactoryBlockOpen.kt#L165: Missing spacing after "="

[hannibal002]

this doesnt look right

[DavidArthurCole]

Could you elaborate more please

[hannibal002]

Have not looked at this in IntelliJ. But this doesn't look like a valid java line. What is the default value of this variable?

[DavidArthurCole]

[hannibal002]

Method naming does not follow Java convention. Methods typically start with a lowercase letter, e.g. simpleTimeMarkFarPast().

The method name is not very descriptive. Consider something like getFarPastSimpleTimeMark() to clarify its intent.

If GenericWrapper and getIt() are needed, consider renaming getIt() to something more meaningful.

[hannibal002]

Also why is this wrapper needed?

[DavidArthurCole]

This is not a new thing, this has existed since June.

I'm fine with changing it if you really want me to but this is not a new thing. And the wrapper is needed because you can't assign a Kotlin class value to a Java object unless it's got a static definition, which SimpleTimeMark.farPast() is not. It's the same reason that right below that, we have a wrapper for Duration - they're composed types that simplify to long, making them easy to use in the storage, but initial values have to be wrapped.

[hannibal002]

can we use new SimpleTimeMark(0) instead then? really not a fan of this wrapping, and the function name breaks java conversations. so sad i have not noticed this before

[DavidArthurCole]

No we cannot.

[github-actions]

One or more Detekt Failures were detected:

• ChocolateFactoryBlockOpen.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
• NonGodPotEffectDisplay.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
• EffectDurationChangeEvent.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.

[github-actions]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

[github-actions]

Conflicts have been resolved! 🎉

[github-actions]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

[github-actions]

Conflicts have been resolved! 🎉

[github-actions]

One or more Detekt Failures were detected:

• ChocolateFactoryBlockOpen.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
• NonGodPotEffectDisplay.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
• EffectAPI.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.