Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement + Fix: Stonks Auction Not Showing The Right Price #3014

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

im-h
Copy link
Contributor

@im-h im-h commented Dec 2, 2024

What

Fixes the regex pattern for the Stonks Auction not matching the current bracket the player is in and because of that not showing the right price per Stock of Stonks and adds the minimum bid in the price calculation.

Changelog Improvements

  • Included the minimum bid in the Stonks Auction price calculation. - im-h

Changelog Fixes

  • Fixed Stonks Auction not showing the correct price per Stock of Stonks. - im-h

@github-actions github-actions bot added the Bug Fix Bug fixes label Dec 2, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Dec 2, 2024
@im-h im-h changed the title Fix: Stonks Auction Not Showing The Right Price Fix + Improvement: Stonks Auction Not Showing The Right Price Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

I have detected some issues with your pull request:

Title issues:
PR has category 'Improvement' which is not in the changelog. Expected categories: Fix

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added Wrong Title/Changelog There is an error in the title or changelog and removed Wrong Title/Changelog There is an error in the title or changelog labels Dec 4, 2024
@CalMWolfs CalMWolfs merged commit 2a35f08 into hannibal002:beta Dec 4, 2024
11 of 12 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Dec 4, 2024
@hannibal002 hannibal002 changed the title Fix + Improvement: Stonks Auction Not Showing The Right Price Improvement + Fix: Stonks Auction Not Showing The Right Price Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants