Improvement + Fix: Personal Bests Gain #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvement + Fix: Personal Bests Gain
CalMWolfs
requested changes
Nov 28, 2024
src/main/java/at/hannibal2/skyhanni/config/features/garden/PersonalBestsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/garden/GardenConfig.java
Show resolved
Hide resolved
hannibal002
requested changes
Nov 28, 2024
src/main/java/at/hannibal2/skyhanni/config/features/garden/PersonalBestsConfig.java
Outdated
Show resolved
Hide resolved
|
Also you can optimize this here from left to right |
CalMWolfs
requested changes
Nov 29, 2024
src/main/java/at/hannibal2/skyhanni/config/features/garden/PersonalBestsConfig.java
Outdated
Show resolved
Hide resolved
CalMWolfs
reviewed
Nov 29, 2024
src/main/java/at/hannibal2/skyhanni/features/garden/contest/FarmingPersonalBestGain.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: CalMWolfs <[email protected]>
hannibal002
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
What
Fixes incorrect personal best gain calculations if new personal best is over the max pb, adds option to show overflow personal bests.
Changelog Improvements
Changelog Fixes