Improvement: Estimated Item Value Mithril Infusion #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Empa <[email protected]>
Signed-off-by: Empa <[email protected]>
CalMWolfs
approved these changes
Nov 28, 2024
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
…d-item-value-mithril-infusion # Conflicts: # src/main/java/at/hannibal2/skyhanni/features/misc/items/EstimatedItemValueCalculator.kt
…re merge conflicts
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for adding mithril infused minions to estimated item value and chest value. Also removes most .toInternalName() calls in estimated item value to be variables in the class, and adds .toInternalNames() functions for converting a list/set of string to list/set of internal name
Changelog Improvements