Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Disallow unnamed capture groups #2958

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

CalMWolfs
Copy link
Collaborator

@CalMWolfs CalMWolfs commented Nov 20, 2024

What

Cleaned up the logic for adding code issues in detekt
Made a method for finding repo patterns in the code

Disallowed the use of making repo patterns that have unnamed capture groups as this is bad.

Changelog Technical Details

  • Disallowed repo patterns from having unnamed capture groups. - CalMWolfs

@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label Nov 20, 2024
@CalMWolfs CalMWolfs added this to the Version 0.28 milestone Nov 20, 2024
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Nov 20, 2024
Copy link

I have detected some issues with your pull request:

Title issues:
PR title does not match the expected format of 'Category: Title'

Please fix these issues. For the correct format, refer to the pull request template.

@CalMWolfs CalMWolfs changed the title improve issue reporting Backend: Disallow unnamed capture groups Nov 20, 2024
@github-actions github-actions bot added Backend A backend pull request that will be merged soon Detekt Has detekt problem and removed Wrong Title/Changelog There is an error in the title or changelog labels Nov 20, 2024
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Nov 20, 2024
@CalMWolfs CalMWolfs merged commit 2a504a3 into hannibal002:beta Nov 20, 2024
6 checks passed
@CalMWolfs CalMWolfs deleted the no-unnamed-captures branch November 20, 2024 02:42
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant