Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow backspace in various editable fields on macOS #2951

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

mendel3
Copy link
Contributor

@mendel3 mendel3 commented Nov 19, 2024

What

This pull request fixes text deletion for all usages of the TextInput on macOS (namely in the trackers). This doesn't fix the issue of repeated inputs on macOS, this is most likely a LWJGL2 issue, or an issue with isKeyClicked. It fixes the issue that PR #2868 aims to fix but failed to do so.

Changelog Fixes

  • Fixed the inability to delete characters when searching on trackers on Mac (again). - 0xDoge

This doesn't fix the issue of repeated inputs on macOS, this is most likely a LWJGL2 issue, or an issue with isKeyClicked
@github-actions github-actions bot added Bug Fix Bug fixes Wrong Title/Changelog There is an error in the title or changelog labels Nov 19, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Change should start with a letter instead of a number or special character in text: _Actually_ fix inability to delete characters when searching on trackers on Mac.

Title issues:
PR has category 'Fix' which is not in the changelog. Expected categories: Feature

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added the Detekt Has detekt problem label Nov 19, 2024
Copy link

One or more Detekt Failures were detected:

Copy link

I have detected some issues with your pull request:

Title issues:
PR has category 'Fix' which is not in the changelog. Expected categories: Feature

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Detekt Has detekt problem label Nov 19, 2024
Copy link

I have detected some issues with your pull request:

Title issues:
PR has category 'Fix' which is not in the changelog. Expected categories: Feature

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Nov 19, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Nov 19, 2024
@hannibal002 hannibal002 enabled auto-merge (squash) November 20, 2024 21:23
@hannibal002 hannibal002 merged commit 5d1069c into hannibal002:beta Nov 20, 2024
6 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants