Improvement: Add Minecraft Version to jar file name #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalMWolfs
added
the
Soon
github-actions
bot
added
the
Backend
github-actions
bot
removed
Soon
hannibal002
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In preperation for the eventual update of skyhanni to supporting more than one minecraft version, I have added the minecraft version to the jar name when it is built and also made the auto updater search specifically for a jar with that version number so that the correct mod file is downloaded.
Now jar names will be in the format of
SkyHanni-mc1.8.9-0.28.Beta.13.jarThis change to the updater allows this format to be modified later if desired, as long as the whole mc version (1.8.9) is still somewhere in the jar name.
Changelog Improvements
Changelog Technical Details