-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: Add regex test detekt rule #2931
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalMWolfs
added
the
Soon
This Pull Request will be merged within the next couple of betas
label
Nov 15, 2024
github-actions
bot
added
Backend
A backend pull request that will be merged soon
Detekt
Has detekt problem
labels
Nov 15, 2024
One or more Detekt Failures were detected:
|
CalMWolfs
changed the title
Backend: Add REGEX-FAIL and fix some regex and tests
Backend: Add regex test detekt rule
Nov 15, 2024
lgtm to me |
One or more Detekt Failures were detected:
|
github-actions
bot
removed
Soon
This Pull Request will be merged within the next couple of betas
Backend
A backend pull request that will be merged soon
labels
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added a detekt rule to enforce repo patterns to be accompanied by at least one regex test.
This makes sure that each repo pattern has a regex test unless it is a plain string.
Every regex test that accompanies a repo pattern must pass,
Every regex fail test that accompanies a repo pattern must fail
For now all repo patterns that are missing a regex test are baselined, but this means that when they are updated they will require a pattern. I will also try to add some regex tests to a lot of them.
This detekt rule also has possibilities for the future e.g.
(.*)
shouldn't be allowedChangelog Technical Details