Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Add REGEX-FAIL and fix some regex and tests #2930

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

CalMWolfs
Copy link
Collaborator

@CalMWolfs CalMWolfs commented Nov 15, 2024

What

Added REGEX-FAIL which indicates this regex test should not match
Fix up regex tests that dont pass
Fix some regex being across 2 lines
Fixed the same regex being in 2 spots
Upated some info in the contributing guide that relates to repo patterns & detekt

Changelog Technical Details

  • Added REGEX-FAIL for regex tests that are expected to fail. - CalMWolfs

@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label Nov 15, 2024
@CalMWolfs CalMWolfs added this to the Version 0.28 milestone Nov 15, 2024
@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Nov 15, 2024
@CalMWolfs CalMWolfs merged commit 8e3d8f7 into hannibal002:beta Nov 15, 2024
9 of 10 checks passed
@CalMWolfs CalMWolfs deleted the regex-testing branch November 15, 2024 04:05
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant