-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: Active Custom Scoreboard Patterns #2927
Backend: Active Custom Scoreboard Patterns #2927
Conversation
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
One or more Detekt Failures were detected:
|
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good (havent tested)
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/gui/customscoreboard/UnknownLinesHandler.kt
Signed-off-by: J10a1n15 <[email protected]>
Conflicts have been resolved! 🎉 |
What
This Pull Request improves the Custom Scoreboard to only do important regex checks. Each Element now contains their respective patterns and using the showIslands() we now filter out not for the current island important patterns. This should reduce the amount of regex checks by like 60% I assume, so yay more fps (maybe)
/shdebug custom scoreboard
Changelog Technical Details