Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Remove Deprecated Color.withAlpha #2916

Merged

Conversation

j10a1n15
Copy link
Contributor

@j10a1n15 j10a1n15 commented Nov 12, 2024

What

Removes ~32 deprecation messages if I counted correctly
Also can this method just please stay removed ty

Changelog Technical Details

  • Removed deprecated Color.withAlpha method in favor of Color.addAlpha. - j10a1n15

@github-actions github-actions bot added Backend A backend pull request that will be merged soon Wrong Title/Changelog There is an error in the title or changelog labels Nov 12, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Author is not set in text: + Removed Deprecated Color.withAlpha method in favour Color.addAlpha
Change should end with a full stop in text: Removed Deprecated Color.withAlpha method in favour Color.addAlpha

Please fix these issues. For the correct format, refer to the pull request template.

1 similar comment
Copy link

I have detected some issues with your pull request:

Body issues:
Author is not set in text: + Removed Deprecated Color.withAlpha method in favour Color.addAlpha
Change should end with a full stop in text: Removed Deprecated Color.withAlpha method in favour Color.addAlpha

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Nov 12, 2024
@hannibal002
Copy link
Owner

Also can this method just please stay removed ty

you talk about the removal of deprecated functions should not be reverted?
as long as the deprecation got added a long time ago its fine
removing too early breaks the logic behind using deprecation entirely, i could instead just remove the function in the first place.

but we dont want this, we already have enough merge conflicts in open prs.

@j10a1n15
Copy link
Contributor Author

j10a1n15 commented Nov 12, 2024

as long as the deprecation got added a long time ago its fine

it got removed ~1 month ago with #2112

@CalMWolfs CalMWolfs enabled auto-merge (squash) November 12, 2024 23:38
@CalMWolfs CalMWolfs merged commit 00f7ff6 into hannibal002:beta Nov 12, 2024
6 checks passed
@github-actions github-actions bot removed the Backend A backend pull request that will be merged soon label Nov 12, 2024
@j10a1n15 j10a1n15 deleted the backend/colorcolorcolorcolorcolorcolor branch November 13, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants