Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: CF Stray Filter #2907

Merged
merged 11 commits into from
Dec 5, 2024

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Nov 10, 2024

Dependencies

What

Adds the ability to only be notified (pinged & flashed) when strays of a certain rarity or higher appear in the factory, rather than all or nothing.

Don't know what we want to do about what used to be rabbitWarning going away in favor of rabbitWarningType. I can try to do a migration of true -> ALL and false -> NONE, but I'm not sure if that's worth it.

Changelog Improvements

  • Chocolate Factory's "Stray Alerts" and "Screen Flash" can now be filtered by rabbit rarity. - Daveed

@github-actions github-actions bot added the Detekt Has detekt problem label Nov 10, 2024
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Nov 10, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Nov 11, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Nov 11, 2024
@hannibal002
Copy link
Owner

I can try to do a migration of true -> ALL and false -> NONE, but I'm not sure if that's worth it.

i say not worth it

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the config value flashScreenType crashes during startup with old config

@hannibal002 hannibal002 merged commit 0da7414 into hannibal002:beta Dec 5, 2024
6 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Dec 5, 2024
@DavidArthurCole DavidArthurCole deleted the HoppityTextureData branch December 5, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants