-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: CF Stray Filter #2907
Merged
hannibal002
merged 11 commits into
hannibal002:beta
from
DavidArthurCole:HoppityTextureData
Dec 5, 2024
Merged
Improvement: CF Stray Filter #2907
hannibal002
merged 11 commits into
hannibal002:beta
from
DavidArthurCole:HoppityTextureData
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One or more Detekt Failures were detected:
|
hannibal002
added
the
Soon
This Pull Request will be merged within the next couple of betas
label
Nov 11, 2024
I can try to do a migration of true -> ALL and false -> NONE, but I'm not sure if that's worth it. i say not worth it |
hannibal002
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the config value flashScreenType
crashes during startup with old config
hannibal002
approved these changes
Dec 5, 2024
github-actions
bot
removed
the
Soon
This Pull Request will be merged within the next couple of betas
label
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
What
Adds the ability to only be notified (pinged & flashed) when strays of a certain rarity or higher appear in the factory, rather than all or nothing.
Don't know what we want to do about what used to be
rabbitWarning
going away in favor ofrabbitWarningType
. I can try to do a migration oftrue -> ALL
andfalse -> NONE
, but I'm not sure if that's worth it.Changelog Improvements