Feature: Reopen last storage command #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One or more Detekt Failures were detected:
|
|
Cool idea, can we have the same thing for ender chest as well? |
|
Thank you for your hard work on this feature! I really hope it gets accepted, as it would make me genuinely happy to use it actively. I believe it has a lot of potential, and I appreciate the effort you’ve put into it. |
hannibal002
added
the
Soon
aphased
changed the title
|
Converting to draft since I would still like to add @lunaynx's suggestion (see above) first. |
The newly-added `/lo` will always open the last-used storage irrespective of whether it was an ender chest or backpack page.
One or more Detekt Failures were detected:
|
(`/ec -1` works Hypixel-side, but not in the `/ec -` command logic)
One or more Detekt Failures were detected:
|
One or more Detekt Failures were detected:
|
hannibal002
requested changes
Dec 7, 2024
src/main/java/at/hannibal2/skyhanni/features/commands/OpenLastStorage.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/commands/OpenLastStorage.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/commands/OpenLastStorage.kt
Outdated
Show resolved
Hide resolved
This drastically reduces repetitiveness. Also, crucially, fixed not updating the last stored _type_ of storage (backpack vs. ender chest), only the page number/index; and this time in the correct location. Also trimmed use of `event.message.startsWith(x, ignoreCase = true)` where possible.
One or more Detekt Failures were detected:
|
One or more Detekt Failures were detected:
|
One or more Detekt Failures were detected:
|
As advised in the #coding channel on Discord. Also renamed both new commands to be prefixed with "sh" (`/shlastopened`, `/shlo`)
One or more Detekt Failures were detected:
|
(`/shlastopened` is a normal user command)
One or more Detekt Failures were detected:
|
I think 🙏
hannibal002
requested changes
Dec 13, 2024
github-actions
bot
removed
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds three new sub-commands as a (configless/always-on) feature. Example:
/bp -(the single dash). Executing it will re-open the backpack that was last opened using/bp [int].The inspiration for this comes from Unix-style
cd -for going to the previous current directory. Also, I'm using/bpand/ecfor brevity everywhere,/backpackand/enderchestwork as well of course.The new command
/shlo(and/shlastopened) will always open the last-used storage irrespective of whether it was an ender chest or backpack page.The key/command combinations are not yet taken AFAIK.
Currently in an unmodded client, executing
/bp -givesCommand Failed: Non-Numeric argument!./ec -opens the first ender chest page, which is also still reachable via/ecor/ec 1/shlastopened(and its short-form variant/shlo) are of course also still unregisteredApart from typing it out as a command (or repeatedly accessing it via the up arrow), this feature also has the advantage that a single hotkey from any number of mods may be defined and used the same way every time you need to access any storage page multiple times in a row for removing/adding some items to it.
Also potentially noteworthy regarding the implementation, I made the explicit decision against resetting the most recent backpack/ender chest slot value in case of a non-integer argument. In this case, it will just keep the previous valid integer backpack number "active".
This feature was first suggested here.
Changelog New Features