Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Added Primal Fear solvers #2771

Merged
merged 13 commits into from
Oct 22, 2024
Merged

Feature: Added Primal Fear solvers #2771

merged 13 commits into from
Oct 22, 2024

Conversation

KeinsWolfi
Copy link
Contributor

@KeinsWolfi KeinsWolfi commented Oct 20, 2024 •
edited by hannibal002
Loading

What

Added Math & Public Speaking Primal Fear solvers

Changelog New Features

  • Added chat solvers for Primal Fears. - Helium9
    • Added solvers for Math and Public Speaking Primal Fears.

Technical Details

  • Added generateRandomString function. - Helium9
  • Fixed spelling in Dev Repo section. - Helium9

@KeinsWolfi
Added Primal Fear solvers
9ff9e1f 
Added Math & Public Speaking Primal Fear solvers
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Oct 20, 2024
@github-actions GitHub Actions
Copy link

I have detected some issues with your pull request:

Body issues:
Change should start with a capital letter in text: generateRandomString function.
Change should end with a full stop in text: MathUtils class for evaluation of an expression
Author is not set in text: + Always in SkyBlock toggle under Dev section
Change should end with a full stop in text: Always in SkyBlock toggle under Dev section
Author is not set in text: + Fixed spelling in Dev Repo section. - your_name_here
Extra info is not filled out in text: * Extra info.

Title issues:
PR title does not match the expected format of 'Category: Title'

Please fix these issues. For the correct format, refer to the pull request template.

@KeinsWolfi KeinsWolfi marked this pull request as draft October 20, 2024 00:21
@hannibal002 hannibal002 removed the Wrong Title/Changelog There is an error in the title or changelog label Oct 20, 2024
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Oct 20, 2024
@github-actions GitHub Actions
Copy link

I have detected some issues with your pull request:

Body issues:
Change should start with a capital letter in text: generateRandomString function.
Change should end with a full stop in text: MathUtils class for evaluation of an expression
Author is not set in text: + Always in SkyBlock toggle under Dev section
Change should end with a full stop in text: Always in SkyBlock toggle under Dev section
Extra info is not filled out in text: * Extra info.

Title issues:
PR title does not match the expected format of 'Category: Title'

Please fix these issues. For the correct format, refer to the pull request template.

@CalMWolfs CalMWolfs removed the Wrong Title/Changelog There is an error in the title or changelog label Oct 20, 2024
@KeinsWolfi
Copy link
Contributor Author

Let me know if you need elaboration on any feature!

hannibal002
hannibal002 reviewed Oct 20, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some first thoughts

src/main/java/at/hannibal2/skyhanni/config/features/dev/DebugConfig.java Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/event/GreatSpookConfig.java Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/event/GreatSpookConfig.java Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/event/PrimalFearSolverConfig.java Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/event/PrimalFearSolverConfig.java Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/spook/TheGreatSpook.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/event/spook/TheGreatSpook.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/utils/MathUtils.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/utils/StringUtils.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/utils/StringUtils.kt Outdated Show resolved Hide resolved
@KeinsWolfi
Changed code to comply with requests from hannibal
84c041f 
Removed MathUtils as it is not needed at the moment
Fixed typos/spelling
@KeinsWolfi
Copy link
Contributor Author

Lmk if you have any other requests!

@Obsidianninja11
Copy link
Contributor

I feel like the descriptions aren't very good. Maybe something like Sends a clickable message in chat to solve the [Math/Public Speaking] Primal Fear.?
May be out of scope for this pr, but having a keybind for the solvers would be good (and then it could work for the commitment phobia)

@KeinsWolfi
Changed wording
48cfb78 
Changed wording in the Solver Config
Changed wording in the Public Speaking solver
@KeinsWolfi
Added primitive keybindfor Primal Fear Solvers
9c0ab3c 
NEEDS TESTING, DIDNT HAVE THE TIME!!
Added a keybind for quick Solving
@KeinsWolfi
Copy link
Contributor Author

NEEDS TESTING!! Im not gonna be home for a bit, can test this evening though.

@KeinsWolfi
Copy link
Contributor Author

Reverting keybind now, when reverted it will be ready for review

@KeinsWolfi
Removed primitive quick Keybind and finished up both solvers
7d4cf53 
Removed the primitive Keybind to quickly solve both fears without opening chat
Finished up both solvers
@KeinsWolfi KeinsWolfi marked this pull request as ready for review October 20, 2024 19:10
@github-actions GitHub Actions
Copy link

I have detected some issues with your pull request:

Title issues:
PR title does not match the expected format of 'Category: Title'

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Oct 20, 2024
@KeinsWolfi KeinsWolfi changed the title Added Primal Fear solvers Feature: Added Primal Fear solvers Oct 20, 2024
@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Oct 20, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Oct 20, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Oct 20, 2024
@KeinsWolfi
Code Cleanup:
00ac94a 
 + Made Bool checks inline
 + Made separate functions for each Primal Fear solver
 + Inlined getting math val
@KeinsWolfi
Code Cleanup
9583d48 
Code Cleanup
@hannibal002 hannibal002 merged commit 51dc464 into hannibal002:beta Oct 22, 2024
5 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Oct 22, 2024
@KeinsWolfi KeinsWolfi deleted the primalFearSolvers branch October 22, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannibal002 hannibal002 hannibal002 approved these changes

@CalMWolfs CalMWolfs Awaiting requested review from CalMWolfs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.28
Development

Successfully merging this pull request may close these issues.
4 participants
@KeinsWolfi @Obsidianninja11 @hannibal002 @CalMWolfs