Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend: TimeLimitedCache #2729

Merged
merged 11 commits into from
Dec 13, 2024
Merged

Backend: TimeLimitedCache #2729

merged 11 commits into from
Dec 13, 2024

Conversation

ItsEmpa
Copy link
Contributor

@ItsEmpa ItsEmpa commented Oct 12, 2024 •
edited by hannibal002
Loading

What

Changes TimeLimitedCache to extend MutableMap instead of Iterator. Also removed some deprecated functions, and deprecated some other ones. Also removed the deprecation on .cancel() inside LorenzEvent

Changelog Technical Details

  • Changed TimeLimitedCache to extend MutableMap instead of Iterator. - Empa

@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Oct 12, 2024
@hannibal002
Copy link
Owner

Also removed the deprecation on .cancel() inside LorenzEvent

since the whole of lorenz event is deprecated, there is no need to use the function. this is just an additional marker that when using deprecated functions you want to migrate them over to skyhanni event, like every other instance of lorenz event as well

@hannibal002 hannibal002 added this to the Version 0.28 milestone Oct 12, 2024
@ItsEmpa
Copy link
Contributor Author

ItsEmpa commented Oct 12, 2024

Also removed the deprecation on .cancel() inside LorenzEvent

since the whole of lorenz event is deprecated, there is no need to use the function. this is just an additional marker that when using deprecated functions you want to migrate them over to skyhanni event, like every other instance of lorenz event as well

i feel like you should only actually be able to see that LorenzEvent is deprecated if you want to create a new event. if you want to cancel an already existing event (such as cancelling a message with LorenzChatEvent), you shouldnt be told that the function to cancel the event is deprecated.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 18, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@ItsEmpa
Merge branch 'beta' into backend/time-limited-cache-map
6c845c5 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/utils/TimeLimitedCache.kt
#	src/main/java/at/hannibal2/skyhanni/utils/TimeLimitedSet.kt
@ItsEmpa
fix merge
4d7d6e0
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Oct 19, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Nov 1, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Nov 22, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@CalMWolfs
Merge branch 'refs/heads/beta' into fork/ItsEmpa/backend/time-limited…
2ff4c2d 
…-cache-map

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/dungeon/DungeonHighlightClickedBlocks.kt
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Nov 22, 2024
hannibal002
hannibal002 requested changes Nov 28, 2024
View reviewed changes
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets discuss

src/main/java/at/hannibal2/skyhanni/utils/TimeLimitedSet.kt Outdated Show resolved Hide resolved
@ItsEmpa ItsEmpa requested a review from hannibal002 November 29, 2024 08:20
@github-actions github-actions bot added the Detekt Has detekt problem label Nov 29, 2024
@github-actions GitHub Actions
Copy link

One or more Detekt Failures were detected:

@ItsEmpa ItsEmpa force-pushed the backend/time-limited-cache-map branch from 3f54ead to f24b65e Compare December 5, 2024 14:12
@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 5, 2024
@hannibal002 hannibal002 removed the Soon This Pull Request will be merged within the next couple of betas label Dec 8, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Dec 13, 2024
@hannibal002 hannibal002 merged commit 090e307 into hannibal002:beta Dec 13, 2024
6 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nea89o nea89o nea89o left review comments

@hannibal002 hannibal002 hannibal002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.28
Development

Successfully merging this pull request may close these issues.
4 participants
@ItsEmpa @hannibal002 @nea89o @CalMWolfs