Feature: Hoppity Purse Blocker #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityCallWarning.kt
Show resolved
Hide resolved
Once you open the hoppity call (i.e., click Yes), if you don't have coins, you lose out on the offer - so, block opening the call if you don't have coins. Not sure if the config needs updating. |
|
Yeah, that makes sense. But that isn't what the config reads to me. Since I thought it was about the normal hoppity shop, which didn't make sense. |
Thunderblade73
approved these changes
Oct 4, 2024
DavidArthurCole
force-pushed
the
HoppityCoinBlocker
branch
from
2eb282b
to
387407f
Compare
CalMWolfs
requested changes
Oct 8, 2024
src/main/java/at/hannibal2/skyhanni/features/event/hoppity/HoppityCallWarning.kt
Show resolved
Hide resolved
CalMWolfs
approved these changes
Oct 8, 2024
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
hannibal002
added
the
Soon
github-actions
bot
removed
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a blocker to prevent opening Hoppity's shop without coins.
Changelog New Features