-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: DownloadSourceChecker #1914
Feature: DownloadSourceChecker #1914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, but there are some minor nit picks
src/main/java/at/hannibal2/skyhanni/tweaker/SkyHanniTweaker.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/tweaker/DownloadSourceChecker.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/tweaker/DownloadSourceChecker.java
Outdated
Show resolved
Hide resolved
Doeesnt work for me. |
try with a different browser, Firefox is known to not implement standard systems that most browsers have. |
zone identifier is a windows feature, should be independent of firefox, right? |
Its a standard set by windows and every browser but seemingly if it is not working for you then firefox is not doing this standard and is not going through the proper download procedure . I know for a fact it works with chrome and edge because I tested on both. Firefox accounts for less than 4% of all browsers so it being a problem isnt going to affect that many people, this is just a precautionary system it is not a full proof thing, it wont stop everything but will prevent basic attempts. |
Just tested with chrome, didn't work as well. Ive copied the link from the discord message that contained the file, pasted it in chrome. let it download, moved the downloaded file from chrome downloads folder to my prism profile mods folder, started prism. now i see the start screen of mc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked for me. (patience is key)
What
This adds a checker that will check the validity of the jar that the mod is being ran from.
When a jar is ran using this and the jar is downloaded from an untrusted source like Discord then a pop up will show up, this popup will inform the user about the dangers of running an untrusted jar.
As of right now there are only 2 trusted sources:
This should stop basic attempts of just shoving crappy malware into SkyHanni to have it look similar to SkyHanni in file contents.
There is an override/skip option that will ask for a "password", this menu will also explain again that they should not be trusting people and as a last resort the password says they are in danger.
Note: This is for windows only.
Images
Changelog New Features