Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Change lava color #1885

Merged
merged 18 commits into from
Oct 11, 2024
Merged

Feature: Change lava color #1885

merged 18 commits into from
Oct 11, 2024

Conversation

superhize
Copy link
Contributor

@superhize superhize commented May 24, 2024 •
edited by hannibal002
Loading

What

Change lava color instead of using a ressource pack.

Images

2024-05-26_19 26 00

direct

Changelog New Features

  • Added Lava Replacement. - HiZe
    • Replaces the lava texture with the water texture.
    • Primarily used for lava fishing in the Crimson Isle, but can be used anywhere else if the option is enabled.

@superhize superhize marked this pull request as ready for review May 26, 2024 18:09
@hannibal002 hannibal002 added this to the Version 0.26 milestone May 26, 2024
@hannibal002 hannibal002 changed the title Add: Change lava color Feature: Change lava color May 27, 2024
CalMWolfs
CalMWolfs requested changes Jun 1, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also idk what sbe does for this but does it also work with sbe as redirects can be incompatible

src/main/java/at/hannibal2/skyhanni/config/features/fishing/LavaReplacementConfig.java Outdated Show resolved Hide resolved
@superhize
Copy link
Contributor Author

Also idk what sbe does for this but does it also work with sbe as redirects can be incompatible

It conflict with sbe, that's why I set a higher priority

@CalMWolfs
Copy link
Collaborator

Also idk what sbe does for this but does it also work with sbe as redirects can be incompatible

It conflict with sbe, that's why I set a higher priority

resolved in my commit

@superhize superhize requested a review from CalMWolfs June 1, 2024 11:44
@NopoTheGamer NopoTheGamer mentioned this pull request Jun 1, 2024
Merged
CalMWolfs
CalMWolfs approved these changes Jun 1, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me (also NotEnoughUpdates/NotEnoughUpdates#1194 fixes a small issue with it)

@jani270 jani270 added the Soon This Pull Request will be merged within the next couple of betas label Aug 26, 2024
@hannibal002 hannibal002 removed the Soon This Pull Request will be merged within the next couple of betas label Sep 23, 2024
@CalMWolfs CalMWolfs added the Soon This Pull Request will be merged within the next couple of betas label Oct 11, 2024
@hannibal002 hannibal002 merged commit 0671e35 into hannibal002:beta Oct 11, 2024
7 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMWolfs CalMWolfs CalMWolfs approved these changes

@hannibal002 hannibal002 hannibal002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.28
Development

Successfully merging this pull request may close these issues.
4 participants
@superhize @CalMWolfs @hannibal002 @jani270