Feature + Fix: Chocfactorykeybinds #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there is a edge case where two items can be brought with one keypress if hovering over an item and pressing a keybind for a different item. this happens as the vanilla keypress is not canceled |
The same edge case exists in harp keybind. If you find a good fix for this, please be so kind and also fix it in harp keybind |
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/inventory/chocolatefactory/ChocolateFactoryAPI.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
hannibal002
requested changes
May 2, 2024
...bal2/skyhanni/config/features/inventory/chocolatefactory/ChocolateFactoryKeybindsConfig.java
Outdated
Show resolved
Hide resolved
...bal2/skyhanni/config/features/inventory/chocolatefactory/ChocolateFactoryKeybindsConfig.java
Outdated
Show resolved
Hide resolved
...n/java/at/hannibal2/skyhanni/features/inventory/chocolatefactory/ChocolateFactoryKeybinds.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
What
Adds keybinds to buy hoppity upgrades. This uses the same code as the keybinds for the harp so i presume it's allowed?
Fixed harp keybinds still allowing vanilla keybinds for swapping slots through
Changelog New Features
Changelog Fixes