Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Last farmed location waypoint #1335

Merged
merged 5 commits into from
May 29, 2024

Conversation

appable0
Copy link
Contributor

@appable0 appable0 commented Apr 1, 2024

What

This PR adds a "Last Farmed" option to the Crop Start Locations feature, which indicates the position of the player when they last farmed a specific crop type. This is intended to allow players to quickly return to farming after killing pests, attending to visitors, etc.

Images

2024-04-01_11 06 33

Changelog New Features

  • Added crop last farmed waypoint. - appable
    • Accessible in the Crop Start Locations section.

@appable0 appable0 changed the title last farmed location waypoint Feature: Last farmed location waypoint Apr 1, 2024
@appable0 appable0 changed the title Feature: Last farmed location waypoint Improvement: Last farmed location waypoint Apr 1, 2024
@hannibal002 hannibal002 added this to the Version 0.25 milestone Apr 1, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Apr 1, 2024
@hannibal002 hannibal002 changed the title Improvement: Last farmed location waypoint Feature: Last farmed location waypoint Apr 5, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature works fine in the game.
Just a visual problem:
maybe move the label below the waypoint for better readability when the waypoint is very close:
image

image

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/features/garden/CropStartLocationConfig.java
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 added Backend A backend pull request that will be merged soon Soon This Pull Request will be merged within the next couple of betas and removed Soon This Pull Request will be merged within the next couple of betas labels Apr 23, 2024
@jani270 jani270 modified the milestones: Version 0.25, Version 0.26 Apr 29, 2024
@hannibal002 hannibal002 removed the Soon This Pull Request will be merged within the next couple of betas label Apr 29, 2024
@appable0 appable0 requested a review from hannibal002 May 18, 2024 02:24
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label May 28, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautiful

@hannibal002 hannibal002 merged commit f6a31d6 into hannibal002:beta May 29, 2024
3 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Backend A backend pull request that will be merged soon labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants