Feature: Add player highlighting for the Punchcard Artifact #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
src/main/java/at/hannibal2/skyhanni/features/rift/everywhere/PunchcardHighlight.kt
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
hannibal002
added
the
Soon
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
github-actions
bot
added
the
Merge Conflicts
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
hannibal002
requested changes
Mar 9, 2024
src/main/java/at/hannibal2/skyhanni/features/rift/everywhere/PunchcardHighlight.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/everywhere/PunchcardHighlight.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/everywhere/PunchcardHighlight.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/everywhere/PunchcardHighlight.kt
Outdated
Show resolved
Hide resolved
|
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
hannibal002
added
the
Soon
hannibal002
requested changes
Jun 16, 2024
src/main/java/at/hannibal2/skyhanni/features/rift/everywhere/PunchcardHighlight.kt
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/everywhere/PunchcardHighlight.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/everywhere/PunchcardHighlight.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/everywhere/PunchcardHighlight.kt
Show resolved
Hide resolved
hannibal002
requested changes
Jun 16, 2024
src/main/java/at/hannibal2/skyhanni/config/features/rift/PunchcardConfig.java
Outdated
Show resolved
Hide resolved
hannibal002
requested changes
Jun 16, 2024
src/main/java/at/hannibal2/skyhanni/features/rift/everywhere/PunchcardHighlight.kt
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/rift/everywhere/PunchcardHighlight.kt
Show resolved
Hide resolved
hannibal002
approved these changes
Jun 16, 2024
github-actions
bot
removed
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Highlights unpunched players in the Rift, for use with the Punchcard Artifact.
Also adds an overlay with how many players were punched in the current session.
both these features have a reverse mode, highlighting only punched players and counting down how many punched players are left.
https://canary.discord.com/channels/997079228510117908/1211833441444823080
Images
current issues:
Changelog New Features