Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t show Options button on disabled extensions #60

Merged
merged 1 commit into from
Dec 25, 2020
Merged

Don’t show Options button on disabled extensions #60

merged 1 commit into from
Dec 25, 2020

Conversation

hankxdev
Copy link
Owner

@hankxdev hankxdev commented Dec 24, 2020 •
edited
Loading

  • currently, it will show options icon even if an extension has no options page. fixed to only show when an extension has options page and enabled (it won't open if it's not enabled)
  • since some extension's options page does not fit well in options_ui mode (chrome://extensions/?options=), so change it to open in normal options page mode (chrome-extension://{ID}/options.html). Make it to open default options view.
    A broken options page sample:

Screen Shot 2020-12-24 at 16 26 55

@hankxdev
Copy link
Owner Author

@fregante Merry Christmas 🎄

@fregante
Copy link
Collaborator

Merry Christmas to you! 🎅🏻

@fregante fregante changed the title fix options url Don’t show Options button on disabled extensions Dec 25, 2020
@fregante fregante merged commit a80939e into master Dec 25, 2020
@fregante fregante deleted the fix-style branch December 25, 2020 06:08
@fregante fregante added the bug label Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hankxdev @fregante