partialName can now be a property. Fixes #189#244
Closed
maho2nd wants to merge 1 commit intohandlebars-lang:masterfrom
maho2nd:master
Closed
partialName can now be a property. Fixes #189#244maho2nd wants to merge 1 commit intohandlebars-lang:masterfrom maho2nd:master
maho2nd wants to merge 1 commit intohandlebars-lang:masterfrom
maho2nd:master
Conversation
Collaborator
|
What's the use case for this? |
Author
Collaborator
|
@maho2nd Ok, makes sense. I'd really like tests for this though. |
|
Would love to see this merge soon. Thanks |
Collaborator
|
We're not likely to merge this without tests. |
|
Great! |
Collaborator
|
I'm closing this for now. If someone submits a pull request with tests, we can reopen the discussion. Thanks! |
|
No worries. I reorganized my code months ago and solved my problem in better ways. I think there are better paths than allowing dynamic partials in most usecases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a partial with the specified name could not be found it will handle the name as a property.