Closed
Conversation
the function "registerDecorator" is now deprecated. The decorator API exposes a lot of internal structures that should not be part of the official API. An alternative API can be discussed at #1574 - "Handlebars.registerDecorator" now logs a warning - "Handlebars.registerDecoratorWithoutDeprecationWarning" can be used in order to omit the warning, when developers have read the notice. (The inline-decorator is using this function now)
Collaborator
Author
This was referenced Jul 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR marks the "registerDecorator" is now deprecated. The
decorator API exposes a lot of internal structures that
should not be part of the official API. An alternative
API can be discussed at #1574
can be used in order to omit the warning, when
developers have read the notice.
(The inline-decorator is using this function now)
I would value comments about whether this is the correct way to introduce a deprecation.
My thoughts:
log might be more visible than an entry in the release-notes
what developers want. In some cases, developer my have a hard time removing the warnings,
because they don't have direct access to the code that uses Handlebars. (like this comment suggests)