Ensure allowCallsToHelperMissing runtime option is optional in typings #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-like-robots
added a commit
to Financial-Times/dotcom-page-kit
that referenced
this pull request
Sep 24, 2019
…id TS bug The latest 4.3.0 release of Handlebars introduced a new option which has been incorrectly declared as mandatory in the associated typings. This is currently failing our builds and I have opened a PR on the dependency here: handlebars-lang/handlebars.js#1560
|
You are right. Thanks. But please see if you can point your PR to the 4.x branch. |
|
Sorted 👍 |
|
I'll add a test to the file |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started getting type errors this morning with the release of
v4.3.0:I believe this property is not actually required so this PR updates the types to ensure it is flagged as optional.