Skip to content

fix: use cjs for browser fields#1555

Merged
nknapp merged 1 commit intohandlebars-lang:4.xfrom
paulfalgout:fix/browser
Sep 20, 2019
Merged

fix: use cjs for browser fields#1555
nknapp merged 1 commit intohandlebars-lang:4.xfrom
paulfalgout:fix/browser

Conversation

@paulfalgout
Copy link
Contributor

We should not be using pre-built files for the browser. Resolves #1553

We should not be using pre-built files for the `browser`.  Resolves handlebars-lang#1553
@paulfalgout
Copy link
Contributor Author

Related to #1540
@ouijan I think this PR is a nonbreaking solution with similar, perhaps improved, results for the issue you were seeing with imports. While I think the packaged min.js file may function in some cases, it's breaking in others... But I think these cjs cover your case and the general. If you don't mind 👀 on this.

@nknapp nknapp merged commit c55a7be into handlebars-lang:4.x Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments