wip: disallow lambdas and functions in input data... #1551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if sandboxing the whole template on execution might be an alternative as well. |
We should not be using pre-built files for the `browser`. Resolves #1553
related to #1553 - registering helpers on an instance retrieved via `import`, compiling the template on an instance retrieved via `require` - using `@roundingwellos/babel-plugin-handlebars-inline-precompile` to load plugins inline
...unless explicitly setting "allowUnsafeFunctionCalls" in the compile options
nknapp
force-pushed
the
unsafe-function-calls
branch
from
81d6825 to
c343711
Compare
|
I'm not sure if this works out. I'll close this and try again later. |
|
Could you review #1559 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...unless explicitly setting "allowUnsafeFunctionCalls"
in the compile options
@ErisDS @wycats I would like your oppinion on this. If you agree, I will add (and fix) tests and docs. Then I'll release this.
Despite the breaking change, I would only bump the patch version, as @ErisDS suggested lately.