parser: Change suffix to use ES6 default module export#1315
parser: Change suffix to use ES6 default module export#1315nknapp merged 1 commit intohandlebars-lang:masterfrom
Conversation
|
This seems good. I wouldn't think the CI failures are related. |
|
yeah, that test failure seems to be unrelated |
|
It's not completely unrelated. The reason is this: The generated file |
|
Coverage-Report of the parser.js file... |
|
Since all the lines in this file have been ignored in the recent builds and I don't think it is possible to cover the entire file, I think it would be OK to exclude the file in .istanbul.yml. @chadhietala could you do that? |
|
@nknapp good point. I've added the |
- This export will be transpiled by Babel for the cjs distribution, but will enable others to use a pure ES6 module distribution - Instanbul: Ignore "parser.js" for coverage reporting. This file was ignored before via annotation, but this has no effect anymore due to the above change - Remove istanbul annotation from `parser-prefix` (@nknapp) Squashed by @nknapp
|
I have squashed the commits (makes it easier to cherry-pick to the 4.x-branch) and removed the now obsolete istanbul annotation from parser-prefix. I hope you didn't mind me force-pushing to your es6-parser branch. |
|
Not at all, thanks! |
This export will be transpiled by Babel for the
cjsdistribution, but will enable others to use a pure ES6 module distribution.Resolves #1313
/cc @chadhietala @mmun