Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundle install step to the getting started guide #250

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

patrickbrown-dev
Copy link

When I was following the guide I had to do this step manually, and those who are newer to the Ruby ecosystem might not know this command is required before the bundle exec hanami dev command.

I hope this is helpful! Happy to change as needed! (Or maybe I did something wrong?)

Best,
Pat

When I was following the guide I had to do this step manually, and
those who are newer to the Ruby ecosystem might not know this
command is required before the `bundle exec hanami dev` command.

I hope this is helpful! Happy to change as needed! (Or maybe I did
something wrong?)

Best,
Pat
@cllns
Copy link
Member

cllns commented Aug 9, 2024

Great find @patrickbrown-dev! Can you do the same for the 2.0 and 2.2 guides so we get this useful change for all recent versions?

@patrickbrown-dev
Copy link
Author

@cllns great idea! I'll update this PR!

@timriley
Copy link
Member

Hi @patrickbrown-dev, thanks for this suggestion!

hanami new should already run bundle install for you, so if you have to do this again manually, then I would consider that a bug with hanami new rather than a documentation issue to be fixed.

To this end, could you please have a go making a new app now and telling me if it actually still requires you to bundle install before running bundle exec hanami dev? And if so, any details about the output of hanami new would be useful to know too. This way we can get to the root cause and keep the experience best for all users.

Copy link
Member

@timriley timriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No merge yet, since we'll wait to learn more from @patrickbrown-dev about how hanami new has been working for them.

@patrickbrown-dev
Copy link
Author

@timriley sorry for the delay! I'll take a look into this tonight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants