Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user authentication #117

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add support for user authentication #117

wants to merge 5 commits into from

Conversation

almightycouch
Copy link
Contributor

Add authentication via :user and :pass options.

User accounts have been added to RethinkDB in version 2.3. The default options for connecting are [user: "admin", pass: ""]. The old authentication (using :auth_key) has been removed.

If you wish to provide the old authentication method for backward compatibility, i will update my PR to do so 馃樅.

@almightycouch
Copy link
Contributor Author

Won't compile with Elixir < 1.2. Maybe you should update your .travis.yml to use version 1.2 and 1.3 instead. Also I would test using OPT 18 and 19 instead of 18.0 and 18.1.

@almightycouch
Copy link
Contributor Author

I've updated .travis.yml to work with Elixir 1.3 and both OTP 18 and 19.

  • RethinkDB is now part of the Travis-CI addons and don't have to be installed manually.
  • OTP 19 requires rebar3 which is installed with mix local.rebar.
  • Travis-CI can now run without sudo: required which makes is more lightweight and faster.

@hamiltop
Copy link
Owner

hamiltop commented Nov 7, 2016

Awesome. I'll take a look as soon as I am able. I appreciate the help!

@hamiltop
Copy link
Owner

hamiltop commented Nov 8, 2016

Can we get a test for user auth? Otherwise, this looks great.

@almightycouch
Copy link
Contributor Author

Will write a few tests asap.

* connection authenticates with admin.
* connection fails to authenticate with invalid user.
* connection authenticates with newly created user.
@vorce
Copy link

vorce commented Jan 25, 2017

Any news on this one? I'd love to see this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants