Skip to content

Fix is_() type annotations. #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
offbyone merged 1 commit into from
Aug 11, 2021
Merged

Fix is_() type annotations. #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/hamcrest/core/core/is_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Optional, Type, TypeVar, Union, overload
from typing import Optional, Type, TypeVar, overload, Any
Copy link
Member

@offbyone offbyone Aug 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this probably doesn't pass an isort check

Copy link
Member Author

@brunns brunns Aug 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird - I did run the linting through tox.

Copy link
Member Author

@brunns brunns Aug 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we might have lost isort at some point. Hmph.


from hamcrest.core.base_matcher import BaseMatcher
from hamcrest.core.description import Description
Expand Down Expand Up @@ -46,12 +46,17 @@ def _wrap_value_or_type(x):


@overload
def is_(x: Type) -> Matcher[object]:
def is_(x: Type) -> Matcher[Any]:
...


@overload
def is_(x: Union[Matcher[T], T]) -> Matcher[T]:
def is_(x: Matcher[T]) -> Matcher[T]:
...


@overload
def is_(x: T) -> Matcher[T]:
...


Expand Down
2 changes: 1 addition & 1 deletion tests/type-hinting/test_test_types.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
main: |
from hamcrest.library.text.isequal_ignoring_case import equal_to_ignoring_case

reveal_type(equal_to_ignoring_case("")) # N: Revealed type is 'hamcrest.core.matcher.Matcher[builtins.str]'
reveal_type(equal_to_ignoring_case("")) # N: Revealed type is "hamcrest.core.matcher.Matcher[builtins.str]"