Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkstyle setup #214

Closed
wants to merge 2 commits into from
Closed

Add checkstyle setup #214

wants to merge 2 commits into from

Conversation

krichter722
Copy link
Contributor

@krichter722 krichter722 commented Jul 28, 2018

Requires removal of OpenJDK (or an older checkstyle version which I don't recommend) proposed in #211.

@sf105 sf105 self-assigned this Aug 3, 2018
@sf105
Copy link
Member

sf105 commented Aug 3, 2018

Thanks for putting all this effort it. I'm afraid I'm not keen on checkstyle for a small library maintained by a few people. Some of the warnings are useful, but some are not. For example, I think it's fine to have very small methods on a single line. If we wanted to use checkstyle, I would start with a skeleton implementation and add rules incrementally. In the meantime, I tend to rely on Idea's checking.

@krichter722
Copy link
Contributor Author

krichter722 commented Aug 25, 2019

@sf105 I kept this alive since I'm maintaining a patch of Hamcrest which you refused to merge at some point. I'm providing an update in order to share, not push this PR. I can understand that you want to have your own style. Since most of the work is already done, it's probably easier to go from this patch to create your own rules rather than start your own. As long as you don't enforce a certain code style, you can't control technical debt piling up.

Tests take about 10 seconds longer on Travis CI.

tumbarumba pushed a commit that referenced this pull request Sep 3, 2019
As suggested in #214 the checkstyle setup can be put forward step by
step in order to minimize controversy. The start contains a rule to
enforce spaces instead of tab characters which are already used in
roughly 99.99% of the source.
@tumbarumba
Copy link
Member

I've merged #217. I'm not keen on this PR, as I think it brings in too much.

@tumbarumba tumbarumba closed this Sep 3, 2019
@krichter722
Copy link
Contributor Author

That's fine, you can use it to get inspiration for rules to be added step by step. Static analysis is a one way to quality :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants