Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add uniqueness check for local thumbnail original links and dimensions to avoid duplication #7031

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

guqing
Copy link
Member

@guqing guqing commented Nov 13, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

对本地缩略图的原图链接和尺寸增加唯一性检查避免重复

Does this PR introduce a user-facing change?

对本地缩略图的原图链接和尺寸增加唯一性检查避免重复

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Nov 13, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Nov 13, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Nov 13, 2024
Copy link

f2c-ci-robot bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from guqing. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 57.22%. Comparing base (eff73dc) to head (79de0d5).
Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
...ore/attachment/impl/LocalThumbnailServiceImpl.java 11.11% 8 Missing ⚠️
.../app/core/attachment/extension/LocalThumbnail.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7031      +/-   ##
============================================
+ Coverage     56.99%   57.22%   +0.23%     
- Complexity     3999     4007       +8     
============================================
  Files           714      712       -2     
  Lines         24110    24154      +44     
  Branches       1585     1590       +5     
============================================
+ Hits          13742    13823      +81     
+ Misses         9756     9716      -40     
- Partials        612      615       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

sonarcloud bot commented Nov 15, 2024

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants