Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle plugin entry file loading when cache temp directory is cleared #6238

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jul 1, 2024

What type of PR is this?

/kind bug
/area plugin
/milestone 2.17.x

What this PR does / why we need it:

修复当插件入口文件的缓存目录被系统清理后会导致一直无法加载的问题

原问题复现步骤:

  1. 登录后刷新页面,此时缓存目录被创建
  2. 删除缓存目录后就会提示文件不存在然后导致插件入口文件一致无法加载直到重启 Halo

Which issue(s) this PR fixes:

Fixes #6226

Does this PR introduce a user-facing change?

修复当插件入口文件的缓存目录被系统清理后会导致一直无法加载的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen July 1, 2024 08:32
@f2c-ci-robot f2c-ci-robot bot added the area/plugin Issues or PRs related to the Plugin Provider label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.17%. Comparing base (bc10336) to head (efaee42).
Report is 48 commits behind head on main.

Files Patch % Lines
...core/extension/service/impl/PluginServiceImpl.java 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6238      +/-   ##
============================================
+ Coverage     54.51%   57.17%   +2.66%     
- Complexity     3523     3720     +197     
============================================
  Files           646      648       +2     
  Lines         21862    21988     +126     
  Branches       1528     1542      +14     
============================================
+ Hits          11917    12572     +655     
+ Misses         9328     8805     -523     
+ Partials        617      611       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit b9c500d into halo-dev:main Jul 1, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/plugin Issues or PRs related to the Plugin Provider kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.16.0 出现【加载插件入口文件】失败问题
3 participants