-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add secret select input #6140
Conversation
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6140 +/- ##
============================================
+ Coverage 54.51% 56.93% +2.42%
- Complexity 3523 3702 +179
============================================
Files 646 652 +6
Lines 21862 22038 +176
Branches 1528 1537 +9
============================================
+ Hits 11917 12547 +630
+ Misses 9328 8885 -443
+ Partials 617 606 -11 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
/retitle feat: add secret select input |
Signed-off-by: Ryan Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area ui
/kind feature
/milestone 2.17.x
What this PR does / why we need it:
为 FormKit 添加 Secret 选择组件。
Which issue(s) this PR fixes:
Fixes #5094
Special notes for your reviewer:
Does this PR introduce a user-facing change?