Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method to find path of a specified node in a category tree #6135

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jun 25, 2024

What type of PR is this?

/kind feature
/area core
/milestone 2.17.x

What this PR does / why we need it:

为分类 Finder 提供获取指定节点的面包屑路径方法

Which issue(s) this PR fixes:

Fixes #3374

Does this PR introduce a user-facing change?

为分类 Finder 提供获取指定节点的面包屑路径方法

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 25, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 25, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jun 25, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen June 25, 2024 04:57
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.05%. Comparing base (bc10336) to head (028df99).
Report is 18 commits behind head on main.

Files Patch % Lines
...alo/app/theme/finders/impl/CategoryFinderImpl.java 89.28% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6135      +/-   ##
============================================
+ Coverage     54.51%   57.05%   +2.54%     
- Complexity     3523     3718     +195     
============================================
  Files           646      652       +6     
  Lines         21862    22072     +210     
  Branches       1528     1543      +15     
============================================
+ Hits          11917    12593     +676     
+ Misses         9328     8873     -455     
+ Partials        617      606      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 27, 2024
@guqing guqing marked this pull request as ready for review June 27, 2024 04:47
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang June 27, 2024 04:47
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
Copy link

f2c-ci-robot bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 0cdd043 into halo-dev:main Jun 27, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 27, 2024
@guqing guqing deleted the feature/3374 branch June 27, 2024 10:26
f2c-ci-robot bot pushed a commit to halo-dev/docs that referenced this pull request Jul 4, 2024
### What this PR does?
为分类 Finder API 新增的 getBreadcrumbs 方法提供文档

see also halo-dev/halo#6135

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望分类 finder 提供根据名称获取树路径的方法
3 participants