Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing default values for system settings #6035

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 5, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.16.x

What this PR does / why we need it:

补充缺失的系统设置默认值。

Does this PR introduce a user-facing change?

修复系统设置未保存导致无法正常注册的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 5, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone Jun 5, 2024
@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. area/core Issues or PRs related to the Halo Core labels Jun 5, 2024
Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang June 5, 2024 02:19
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.47%. Comparing base (5fdf6c0) to head (e9e00e0).
Report is 226 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6035      +/-   ##
============================================
- Coverage     56.91%   56.47%   -0.44%     
- Complexity     3319     3541     +222     
============================================
  Files           587      622      +35     
  Lines         18968    20961    +1993     
  Branches       1401     1478      +77     
============================================
+ Hits          10795    11838    +1043     
- Misses         7594     8523     +929     
- Partials        579      600      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/cherrypick release-2.16

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
Copy link

f2c-ci-robot bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2024
@JohnNiang
Copy link
Member

/cherrypick release-2.16

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.16 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot merged commit 2841ff8 into halo-dev:main Jun 5, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #6036

In response to this:

/cherrypick release-2.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang JohnNiang modified the milestones: 2.16.x, 2.17.x Jun 5, 2024
f2c-ci-robot bot pushed a commit that referenced this pull request Jun 5, 2024
This is an automated cherry-pick of #6035

/assign JohnNiang

```release-note
修复系统设置未保存导致无法正常注册的问题
```
ruibaby added a commit to ruibaby/halo that referenced this pull request Jun 6, 2024
#### What type of PR is this?

/kind bug
/area core
/milestone 2.16.x

#### What this PR does / why we need it:

补充缺失的系统设置默认值。

#### Does this PR introduce a user-facing change?

```release-note
修复系统设置未保存导致无法正常注册的问题
```
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants