-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: logic of singlePage setting modal #5968
refactor: logic of singlePage setting modal #5968
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5968 +/- ##
============================================
- Coverage 56.91% 56.76% -0.15%
- Complexity 3319 3486 +167
============================================
Files 587 611 +24
Lines 18968 20523 +1555
Branches 1401 1419 +18
============================================
+ Hits 10795 11650 +855
- Misses 7594 8293 +699
- Partials 579 580 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ryan Wang <[email protected]>
d1a2f0e
to
e3ccdc8
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/area ui
/kind improvement
/milestone 2.16.x
What this PR does / why we need it:
优化页面设置弹窗的显示逻辑,改为在未打开弹窗组件的时候不渲染组件,减少不必要的请求。
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?