refactor: logic of singlePage setting modal #5968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
f2c-ci-robot
bot
added
the
kind/improvement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5968 +/- ##
============================================
- Coverage 56.91% 56.76% -0.15%
- Complexity 3319 3486 +167
============================================
Files 587 611 +24
Lines 18968 20523 +1555
Branches 1401 1419 +18
============================================
+ Hits 10795 11650 +855
- Misses 7594 8293 +699
- Partials 579 580 +1 ☔ View full report in Codecov by Sentry. |
ruibaby
requested review from
JohnNiang,
LIlGG and
guqing
and removed request for
QuentinHsu and
wzrove
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Signed-off-by: Ryan Wang <[email protected]>
ruibaby
force-pushed
the
refactor/singlepage-setting-modal
branch
from
d1a2f0e
to
e3ccdc8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area ui
/kind improvement
/milestone 2.16.x
What this PR does / why we need it:
优化页面设置弹窗的显示逻辑，改为在未打开弹窗组件的时候不渲染组件，减少不必要的请求。
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?