Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve code base of attachment-related #5967

Merged
merged 2 commits into from
May 23, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 22, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.16.x

What this PR does / why we need it:

优化附件管理的相关代码。

  1. 优化附件管理相关的对话框组件,减少重复和不必要的请求。
  2. 简化附件存储策略编辑组件的逻辑。

Special notes for your reviewer:

需要测试:

  1. 附件上传的相关功能。
  2. 附件存储策略的编辑和新建。
  3. 附件筛选条件功能。

Does this PR introduce a user-facing change?

优化附件管理相关代码,减少重复和不必要的请求。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 22, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 22, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label May 22, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wzrove May 22, 2024 07:55
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.76%. Comparing base (5fdf6c0) to head (2112317).
Report is 189 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5967      +/-   ##
============================================
- Coverage     56.91%   56.76%   -0.15%     
- Complexity     3319     3486     +167     
============================================
  Files           587      611      +24     
  Lines         18968    20523    +1555     
  Branches       1401     1419      +18     
============================================
+ Hits          10795    11650     +855     
- Misses         7594     8293     +699     
- Partials        579      580       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby ruibaby requested review from JohnNiang and guqing and removed request for wzrove May 22, 2024 08:52
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
Copy link

f2c-ci-robot bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot merged commit 89b20bf into halo-dev:main May 23, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants