Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: optimize code block backspace shortcut key logic #5936

Merged
merged 2 commits into from
May 21, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented May 17, 2024

What type of PR is this?

/kind improvement
/area editor
/milestone 2.16.x

What this PR does / why we need it:

优化默认编辑器代码块 Backspace 快捷键逻辑。如下所示:

  1. 选中内容时进行删除,保证光标仍处于代码块内。
  2. 光标处于代码块首位或者代码块没有内容时,不再删除代码块。

How to test it?

测试默认编辑器代码块功能。查看是否符合上述逻辑

Which issue(s) this PR fixes:

Fixes #5927

Does this PR introduce a user-facing change?

优化默认编辑器代码块 Backspace 快捷键逻辑

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 17, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 17, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label May 17, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and lan-yonghui May 17, 2024 03:14
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (5fdf6c0) to head (9293a25).
Report is 183 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5936      +/-   ##
============================================
- Coverage     56.91%   56.83%   -0.08%     
- Complexity     3319     3498     +179     
============================================
  Files           587      612      +25     
  Lines         18968    20555    +1587     
  Branches       1401     1420      +19     
============================================
+ Hits          10795    11682     +887     
- Misses         7594     8293     +699     
- Partials        579      580       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

/approve

Copy link

f2c-ci-robot bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit b762a9d into halo-dev:main May 21, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

删除代码块中的内容时,光标出现在代码块之外
4 participants