Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cursor misalignment when scrolling through the table #5928

Merged
merged 1 commit into from
May 16, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented May 16, 2024

What type of PR is this?

/kind bug
/area editor
/milestone 2.16.x

What this PR does / why we need it:

目前表格在监听到滚动时,会重新设置 TextSelection 用于阴影的显示。
本 PR 将设置 TextSelection 更改为重新执行一次 Transaction 。这样可以解决在滚动时光标错位的问题。

How to test it?

编写表格时,测试当编写内容出现滚动条时,是否会导致文本错位。
测试滚动表格时,光标位置是否会发生改变。

Which issue(s) this PR fixes:

Fixes #5924

Does this PR introduce a user-facing change?

解决默认编辑器中滚动表格时会导致光标变换的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 16, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 16, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label May 16, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and JohnNiang May 16, 2024 04:48
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.61%. Comparing base (5fdf6c0) to head (39646c2).
Report is 170 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5928      +/-   ##
============================================
- Coverage     56.91%   56.61%   -0.30%     
- Complexity     3319     3467     +148     
============================================
  Files           587      612      +25     
  Lines         18968    20524    +1556     
  Branches       1401     1419      +18     
============================================
+ Hits          10795    11619     +824     
- Misses         7594     8322     +728     
- Partials        579      583       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
Copy link

f2c-ci-robot bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 33e6c9e into halo-dev:main May 16, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

默认编辑器表格出现滚动条时光标位置错误
3 participants