-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cursor misalignment when scrolling through the table #5928
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5928 +/- ##
============================================
- Coverage 56.91% 56.61% -0.30%
- Complexity 3319 3467 +148
============================================
Files 587 612 +25
Lines 18968 20524 +1556
Branches 1401 1419 +18
============================================
+ Hits 10795 11619 +824
- Misses 7594 8322 +728
- Partials 579 583 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area editor
/milestone 2.16.x
What this PR does / why we need it:
目前表格在监听到滚动时,会重新设置
TextSelection
用于阴影的显示。本 PR 将设置
TextSelection
更改为重新执行一次Transaction
。这样可以解决在滚动时光标错位的问题。How to test it?
编写表格时,测试当编写内容出现滚动条时,是否会导致文本错位。
测试滚动表格时,光标位置是否会发生改变。
Which issue(s) this PR fixes:
Fixes #5924
Does this PR introduce a user-facing change?