-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: style issue of dialog component icon #5910
Conversation
@lan-yonghui: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5910 +/- ##
============================================
- Coverage 56.91% 56.51% -0.40%
- Complexity 3319 3462 +143
============================================
Files 587 612 +25
Lines 18968 20473 +1505
Branches 1401 1413 +12
============================================
+ Hits 10795 11570 +775
- Misses 7594 8322 +728
- Partials 579 581 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area core
/area ui
What this PR does / why we need it:
dialog 组件在标题内容过多的时候,icon 会很小,样式出现错位!
Does this PR introduce a user-facing change?