Refine problem detail when plugin is already installed #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
Closed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
f2c-ci-robot bot
pushed a commit
to halo-dev/console
that referenced
this pull request
Feb 21, 2023
#### What type of PR is this? /kind feature #### What this PR does / why we need it: 安装已存在插件时，支持提示和升级插件。 #### Which issue(s) this PR fixes: Fixes halo-dev/halo#3164 #### Screenshots: <img width="1411" alt="image" src="https://user-images.githubusercontent.com/21301288/220118697-12fbd7a7-57e6-47bb-a03b-b9c280571687.png"> #### Special notes for your reviewer: 测试方式： 1. Halo 需要切换到 halo-dev/halo#3350 分支。 2. 在插件为 deployment 模式下启动 Halo。 3. 安装任意一个插件，然后继续上传安装相同插件。 4. 观察是否提示升级此插件。 #### Does this PR introduce a user-facing change? ```release-note Console 端安装已存在插件时，支持提示并升级插件。 ```
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
…dev/console#871) #### What type of PR is this? /kind feature #### What this PR does / why we need it: 安装已存在插件时，支持提示和升级插件。 #### Which issue(s) this PR fixes: Fixes halo-dev#3164 #### Screenshots: <img width="1411" alt="image" src="https://user-images.githubusercontent.com/21301288/220118697-12fbd7a7-57e6-47bb-a03b-b9c280571687.png"> #### Special notes for your reviewer: 测试方式： 1. Halo 需要切换到 halo-dev#3350 分支。 2. 在插件为 deployment 模式下启动 Halo。 3. 安装任意一个插件，然后继续上传安装相同插件。 4. 观察是否提示升级此插件。 #### Does this PR introduce a user-facing change? ```release-note Console 端安装已存在插件时，支持提示并升级插件。 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area core
What this PR does / why we need it:
This PR refines problem detail of PluginAlreadyExistsException. Please note the new type
https://halo.run/probs/plugin-alreay-existsand additional propertypluginNameof problem detail.Meanwhile
Before
{ "type": "about:blank", "title": "Plugin Already Exists Error", "status": 400, "detail": "Plugin PluginCommentWidget already exists.", "instance": "/apis/api.console.halo.run/v1alpha1/plugins/install", "requestId": "880fe8cd-5", "timestamp": "2023-02-20T10:17:21.541104Z" }After
{ "type": "https://halo.run/probs/plugin-alreay-exists", "title": "Plugin Already Exists Error", "status": 400, "detail": "Plugin PluginCommentWidget already exists.", "instance": "/apis/api.console.halo.run/v1alpha1/plugins/install", "pluginName": "PluginCommentWidget", "requestId": "880fe8cd-5", "timestamp": "2023-02-20T10:17:21.541104Z" }Which issue(s) this PR fixes:
Fixes #3164
Special notes for your reviewer:
Does this PR introduce a user-facing change?