Refine exception detail with i18n #3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/feature
f2c-ci-robot
bot
added
the
kind/api-change
JohnNiang
changed the title
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
|
/assign @halo-dev/sig-halo |
ruibaby
requested changes
Dec 26, 2022
ruibaby
approved these changes
Dec 26, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Closed
|
?? 就合并了 |
|
此 RP 将导致主题异常模板失效，始终只会渲染 Core 提供的默认异常模板 |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
/area core
/milestone 2.1.x
What this PR does / why we need it:
ResponseStatusExceptionto control what HTTP status and problem detail need to be returned.TODO
Which issue(s) this PR fixes:
Fixes #3020
Special notes for your reviewer:
Steps to test:
src/main/resources/config/i18n/messages_zh.propertiesand switch Browser language with Chinese.Does this PR introduce a user-facing change?