Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: archives in descending order by month #2959

Merged
merged 3 commits into from
Dec 16, 2022
Merged

feat: archives in descending order by month #2959

merged 3 commits into from
Dec 16, 2022

Conversation

liaocp666
Copy link
Contributor

What type of PR is this?

/kind improvement

What this PR does / why we need it:

优化归档页面数据排序，按月份降序

Which issue(s) this PR fixes:

Fixes #2958

Special notes for your reviewer:

/cc @halo-dev/sig-halo

Does this PR introduce a user-facing change?

归档数据按月降序

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 15, 2022
@ruibaby
Copy link
Member

ruibaby commented Dec 15, 2022

@liaocp666 感谢你的贡献，在 Review 前需要先处理一下格式的问题 https://github.com/halo-dev/halo/actions/runs/3701412755/jobs/6271059361

@liaocp666
Copy link
Contributor Author

@ruibaby 已处理

guqing
guqing reviewed Dec 15, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2022
@ruibaby ruibaby changed the title feat: Archives in descending order by month feat: archives in descending order by month Dec 15, 2022
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2022
ruibaby
ruibaby approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

符合预期。

image

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@ruibaby
Copy link
Member

ruibaby commented Dec 15, 2022

感谢 @liaocp666 的发现和贡献。

JohnNiang
JohnNiang approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank @liaocp666 for your contribution!

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 2a9a394 into halo-dev:main Dec 16, 2022
@JohnNiang JohnNiang added kind/bug Categorizes issue or PR as related to a bug. and removed kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 16, 2022
@JohnNiang
Copy link
Member

/cherry-pick release-2.0

@halo-dev-bot halo-dev-bot mentioned this pull request Dec 16, 2022
Merged
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #2975

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Dec 16, 2022
@halo-dev-bot
[release-2.0] feat: archives in descending order by month (#2975)
8cbf16a 
This is an automated cherry-pick of #2959

/assign JohnNiang

```release-note
归档数据按月降序
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@ruibaby ruibaby ruibaby approved these changes

Assignees

@JohnNiang JohnNiang

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

归档页面数据，未按月份倒序
6 participants
@liaocp666 @CLAassistant @ruibaby @JohnNiang @halo-dev-bot @guqing