Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

插件安装如果异常提示不明确 #2932

Closed
ruibaby opened this issue Dec 13, 2022 · 7 comments
Closed

插件安装如果异常提示不明确 #2932

ruibaby opened this issue Dec 13, 2022 · 7 comments
Assignees
Labels
area/console Issues or PRs related to the Halo Console area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement.
Milestone

Comments

@ruibaby
Copy link
Member

ruibaby commented Dec 13, 2022

是什么版本出现了此问题?

2.0.1

使用的什么数据库?

PostgreSQL

使用的哪种方式部署?

Docker Compose

在线站点地址

https://demo.halo.run

发生了什么?

如图,当插件上传安装异常,仅会提示异常,没有明确原因,且接口返回内容为空。

image

升级会返回异常原因,但前端没有输出:

image

/area core
/area console
/kind improvement
/milstone 2.1.x

相关日志输出

No response

附加信息

No response

@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 13, 2022
@ruibaby
Copy link
Member Author

ruibaby commented Dec 13, 2022

/milestone 2.1.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.1.x milestone Dec 13, 2022
@JohnNiang
Copy link
Member

/assign

f2c-ci-robot bot pushed a commit to halo-dev/console that referenced this issue Dec 14, 2022
…769)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

优化上传组件的异常提示信息。

#### Which issue(s) this PR fixes:

Fixes halo-dev/halo#2933
Ref halo-dev/halo#2932 halo-dev/halo#2931

#### Screenshots:

<img width="794" alt="image" src="https://user-images.githubusercontent.com/21301288/207272593-b94efb0a-7033-4ec1-b1eb-f2e3871b34f0.png">
<img width="674" alt="image" src="https://user-images.githubusercontent.com/21301288/207272682-0c223d29-8c4f-45b0-a8d5-2432a97835c6.png">


#### Special notes for your reviewer:

测试方式:

1. 进入附件上传、插件安装、主题安装界面。
2. 上传不符合规则的文件,比如主题可以上传一个不是主题的 zip 或者 Halo 1.x 版本的 zip。
3. 观察是否有异常提示。

#### Does this PR introduce a user-facing change?

```release-note
优化 Console 端上传组件的异常提示信息。
```
@JohnNiang
Copy link
Member

在我看来,这个问题已经被 halo-dev/console#769 修复了。@ruibaby

@ruibaby
Copy link
Member Author

ruibaby commented Dec 20, 2022

如图,当插件上传安装异常,仅会提示异常,没有明确原因,且接口返回内容为空。

@JohnNiang

@ruibaby
Copy link
Member Author

ruibaby commented Dec 20, 2022

image

确实可以正确提示,但是浏览器的 Response 为空,不太明白为什么。

@ruibaby
Copy link
Member Author

ruibaby commented Dec 20, 2022

/assign

see halo-dev/console#769

/close

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 20, 2022

@ruibaby: Closing this issue.

In response to this:

/assign

see halo-dev/console#769

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang JohnNiang modified the milestones: 2.1.x, 2.1.0 Dec 20, 2022
JohnNiang pushed a commit to JohnNiang/halo that referenced this issue Mar 2, 2023
…alo-dev/console#769)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

优化上传组件的异常提示信息。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2933
Ref halo-dev#2932 halo-dev#2931

#### Screenshots:

<img width="794" alt="image" src="https://user-images.githubusercontent.com/21301288/207272593-b94efb0a-7033-4ec1-b1eb-f2e3871b34f0.png">
<img width="674" alt="image" src="https://user-images.githubusercontent.com/21301288/207272682-0c223d29-8c4f-45b0-a8d5-2432a97835c6.png">


#### Special notes for your reviewer:

测试方式:

1. 进入附件上传、插件安装、主题安装界面。
2. 上传不符合规则的文件,比如主题可以上传一个不是主题的 zip 或者 Halo 1.x 版本的 zip。
3. 观察是否有异常提示。

#### Does this PR introduce a user-facing change?

```release-note
优化 Console 端上传组件的异常提示信息。
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/console Issues or PRs related to the Halo Console area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Development

No branches or pull requests

2 participants