Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

refactor: use tanstack query to refactor comment-related fetching #892

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 27, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

使用 TanStack Query 重构评论管理相关数据请求的相关逻辑。

Which issue(s) this PR fixes:

Ref halo-dev/halo#3360

Special notes for your reviewer:

测试方式:

  1. 测试评论管理列表的数据请求 + 条件筛选无异常即可。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Feb 27, 2023
@vercel
Copy link

vercel bot commented Feb 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 28, 2023 at 2:57PM (UTC)

@LIlGG
Copy link
Member

LIlGG commented Feb 28, 2023

测试删除评论时,无法刷新页面

image

@ruibaby
Copy link
Member Author

ruibaby commented Feb 28, 2023

测试删除评论时,无法刷新页面

Fixed

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit edf51fb into halo-dev:main Feb 28, 2023
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Mar 1, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…lo-dev/console#892)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

使用 [TanStack Query](https://github.com/TanStack/query) 重构评论管理相关数据请求的相关逻辑。

#### Which issue(s) this PR fixes:

Ref halo-dev#3360

#### Special notes for your reviewer:

测试方式:

1. 测试评论管理列表的数据请求 + 条件筛选无异常即可。

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants